Skip to content

Conversation

@iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_0_X/rootmaster.

@cmsbuild, @iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 15, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e11609/36816/summary.html
COMMIT: fea0ab5
CMSSW: CMSSW_14_0_ROOT6_X_2024-01-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8936/36816/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
Requested to quit.
Requested to quit.
* The action "build-external+dd4hep+v01-27-01-9a09d098bfabcb4d3f53a83d5e6b35c3" was not completed successfully because Failed to build dd4hep. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-9a09d098bfabcb4d3f53a83d5e6b35c3/log. Final lines of the log file:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-9a09d098bfabcb4d3f53a83d5e6b35c3/dd4hep-v01-27-01/DDCore/src/ShapeUtilities.cpp: In function 'std::vector dd4hep::dimensions(const TGeoShape*) [with T = TGeoTessellated]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-9a09d098bfabcb4d3f53a83d5e6b35c3/dd4hep-v01-27-01/DDCore/src/ShapeUtilities.cpp:437:36: error: 'const class TGeoFacet' has no member named 'GetVertexIndex'
437 |         pars.emplace_back(double(f.GetVertexIndex(j)));
|                                    ^~~~~~~~~~~~~~
[ 34%] Building CXX object DDCore/CMakeFiles/DDCore.dir/src/XML/Layering.cpp.o
cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-9a09d098bfabcb4d3f53a83d5e6b35c3/build/DDCore && /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -DBOOST_SPIRIT_USE_PHOENIX_V3 -DDD4HEP_USE_GEANT4_UNITS=1 -DDD4HEP_USE_XERCESC -DDDCore_EXPORTS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-9a09d098bfabcb4d3f53a83d5e6b35c3/dd4hep-v01-27-01/DDCore/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-9a09d098bfabcb4d3f53a83d5e6b35c3/dd4hep-v01-27-01/DDParsers/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-10cf4b7ad122d942e0dad0b04ba52a1f/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-9d4e0dc8cf1f8fc8a67cf53ae917955e/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -ftls-model=global-dynamic -Wno-psabi -pedantic -Wextra -Wall -fdiagnostics-color=auto -Wdeprecated -Wno-long-long -Wformat-security -Wshadow -fPIC  -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr           -pthread -O3 -DNDEBUG -fPIC -std=c++17 -MD -MT DDCore/CMakeFiles/DDCore.dir/src/XML/Layering.cpp.o -MF CMakeFiles/DDCore.dir/src/XML/Layering.cpp.o.d -o CMakeFiles/DDCore.dir/src/XML/Layering.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-9a09d098bfabcb4d3f53a83d5e6b35c3/dd4hep-v01-27-01/DDCore/src/XML/Layering.cpp
make[2]: *** [DDCore/CMakeFiles/DDCore.dir/build.make:1336: DDCore/CMakeFiles/DDCore.dir/src/ShapeUtilities.cpp.o] Error 1


@cmsbuild
Copy link
Contributor

Pull request #8936 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e11609/36818/summary.html
COMMIT: 2071e91
CMSSW: CMSSW_14_0_ROOT6_X_2024-01-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8936/36818/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

[ 82%] Building CXX object DDG4/CMakeFiles/DDG4.dir/src/Geant4VolumeManager.cpp.o
cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/build-g4/DDG4 && /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -DBOOST_SPIRIT_USE_PHOENIX_V3 -DDD4HEP_USE_GEANT4_UNITS=1 -DDD4HEP_USE_XERCESC -DG4LIB_BUILD_DLL -DG4UI_USE_TCSH -DPTL_BUILD_DLL -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDG4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDCore/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDParsers/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-10cf4b7ad122d942e0dad0b04ba52a1f/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-9d4e0dc8cf1f8fc8a67cf53ae917955e/include -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/geant4/11.1.2-2dc088e2a4a91b8e005747c11ecd4364/include/Geant4 -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/clhep/2.4.7.1-5c1cfd46e8f0e61f022ff44f21c90ce1/include -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/vecgeom/v1.2.7-348781cfa9035af7101d1c38f0673fd2/include -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/expat/2.4.8-b093687a482bf386f8f8c236c5b2efa2/include -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/zlib/1.2.11-51072030b7f93c3ac6c4235f21e413cb/include -ftls-model=global-dynamic -Wno-psabi -pedantic -Wextra -Wall -fdiagnostics-color=auto -Wdeprecated -Wno-long-long -Wformat-security -Wshadow -fPIC  -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr           -pthread -O3 -DNDEBUG -fPIC -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -pthread -ftls-model=global-dynamic -std=c++17 -faligned-new -msse2 -std=c++17 -MD -MT DDG4/CMakeFiles/DDG4.dir/src/Geant4VolumeManager.cpp.o -MF CMakeFiles/DDG4.dir/src/Geant4VolumeManager.cpp.o.d -o CMakeFiles/DDG4.dir/src/Geant4VolumeManager.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDG4/src/Geant4VolumeManager.cpp
[ 82%] Building CXX object DDG4/CMakeFiles/DDG4.dir/src/IoStreams.cpp.o
cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/build-g4/DDG4 && /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -DBOOST_SPIRIT_USE_PHOENIX_V3 -DDD4HEP_USE_GEANT4_UNITS=1 -DDD4HEP_USE_XERCESC -DG4LIB_BUILD_DLL -DG4UI_USE_TCSH -DPTL_BUILD_DLL -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDG4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDCore/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDParsers/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-10cf4b7ad122d942e0dad0b04ba52a1f/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-9d4e0dc8cf1f8fc8a67cf53ae917955e/include -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/geant4/11.1.2-2dc088e2a4a91b8e005747c11ecd4364/include/Geant4 -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/clhep/2.4.7.1-5c1cfd46e8f0e61f022ff44f21c90ce1/include -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/vecgeom/v1.2.7-348781cfa9035af7101d1c38f0673fd2/include -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/expat/2.4.8-b093687a482bf386f8f8c236c5b2efa2/include -isystem /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/external/zlib/1.2.11-51072030b7f93c3ac6c4235f21e413cb/include -ftls-model=global-dynamic -Wno-psabi -pedantic -Wextra -Wall -fdiagnostics-color=auto -Wdeprecated -Wno-long-long -Wformat-security -Wshadow -fPIC  -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr           -pthread -O3 -DNDEBUG -fPIC -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -pthread -ftls-model=global-dynamic -std=c++17 -faligned-new -msse2 -std=c++17 -MD -MT DDG4/CMakeFiles/DDG4.dir/src/IoStreams.cpp.o -MF CMakeFiles/DDG4.dir/src/IoStreams.cpp.o.d -o CMakeFiles/DDG4.dir/src/IoStreams.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDG4/src/IoStreams.cpp
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDG4/src/Geant4ShapeConverter.cpp: In function 'G4VSolid* dd4hep::sim::convertShape(const TGeoShape*) [with T = TGeoTessellated]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/dd4hep-v01-27-01/DDG4/src/Geant4ShapeConverter.cpp:273:48: error: 'const class TGeoFacet' has no member named 'GetVertexIndex'
273 |           const auto& v3 = sh->GetVertex(facet.GetVertexIndex(3));
|                                                ^~~~~~~~~~~~~~
make[2]: *** [DDG4/CMakeFiles/DDG4.dir/build.make:804: DDG4/CMakeFiles/DDG4.dir/src/Geant4ShapeConverter.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/dd4hep/v01-27-01-1a79e8d5653f0f4d1120a86cd3b226c7/build-g4'


@cmsbuild
Copy link
Contributor

Pull request #8936 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e11609/36819/summary.html
COMMIT: b404db8
CMSSW: CMSSW_14_0_ROOT6_X_2024-01-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8936/36819/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testAlcaBeamMonitor had ERRORS

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

Pull request #8936 was updated.

@iarspider
Copy link
Contributor Author

please test with #8942

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e11609/36839/summary.html
COMMIT: fff166e
CMSSW: CMSSW_14_0_ROOT6_X_2024-01-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8936/36839/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e11609/36839/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e11609/36839/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testAlcaBeamMonitor had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

looks good (unit test failure is not related to this change)

@smuzaffar smuzaffar merged commit 08ce238 into cms-sw:IB/CMSSW_14_0_X/rootmaster Jan 16, 2024
@iarspider iarspider deleted the root-update-master-20240115 branch February 12, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants